Skip to content

Choose an older Kubetest2 commit version instead of using latest and manually set timeout to 24h #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2022
Merged

Choose an older Kubetest2 commit version instead of using latest and manually set timeout to 24h #323

merged 1 commit into from
Jul 15, 2022

Conversation

tyuchn
Copy link
Contributor

@tyuchn tyuchn commented Jul 13, 2022 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
A kubetest2 regression was introduced in kubernetes-sigs/kubetest2#183, it causes our integration tests to fail in both PD and Filestore CSI side. A temp fix is to choose an older Kubetest2 commit version 0e09086b60c122e1084edd2368d3d27fe36f384f over @latest.
Besides, we explicitly set the integration test timeout to 24h. According to kubernetes/kubernetes#109111, timeout has been reduced from 24 hours to 1 hours in k/k repo because Ginkgo v1 is deprecated.
Which issue(s) this PR fixes:

Fixes b/237583494

Special notes for your reviewer:
This is a temp solution to unblock filestore csi 1.2.8 release.

Does this PR introduce a user-facing change?:

N/A

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tyuchn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2022
@tyuchn
Copy link
Contributor Author

tyuchn commented Jul 13, 2022

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@tyuchn: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saikat-royc
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2022
@saikat-royc
Copy link
Member

/test pull-gcp-filestore-csi-driver-kubernetes-integration

@saikat-royc
Copy link
Member

/retest

saikat-royc
saikat-royc reviewed Jul 15, 2022
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2022
@tyuchn tyuchn changed the title Try out kubetest2 version 0e09086b60c122e1084edd2368d3d27fe36f384f Choose an older Kubetest2 commit version instead of using latest and manually set timeout to 24h Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 15, 2022
leiyiz
leiyiz reviewed Jul 15, 2022
View reviewed changes
leiyiz
leiyiz reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits

@tyuchn tyuchn force-pushed the kubetest2-version branch from 28277dd to ae0436f Compare July 15, 2022 17:45
@tyuchn
Copy link
Contributor Author

tyuchn commented Jul 15, 2022

Please squash your commits

Done

@tyuchn tyuchn force-pushed the kubetest2-version branch from ae0436f to eb52047 Compare July 15, 2022 18:06
@leiyiz
Copy link
Contributor

leiyiz commented Jul 15, 2022

/retest

@saikat-royc
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saikat-royc, tyuchn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3eb4aa4 into kubernetes-sigs:master Jul 15, 2022
@tyuchn tyuchn mentioned this pull request Dec 15, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz leiyiz left review comments

@saikat-royc saikat-royc saikat-royc left review comments

@mattcary mattcary Awaiting requested review from mattcary

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyuchn @k8s-ci-robot @saikat-royc @leiyiz